Adding ability to ignore actuators #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribeiro
requested changes
Jul 11, 2023
| items: | ||
| type: number | ||
| enum: [{m1m3_actuator_ids_str}] | ||
| default: [] |
There was a problem hiding this comment.
I think this is line ha the wrong indentation level. It should be one level up
There was a problem hiding this comment.
I saw it just after opening the PR. Already fixed it.
| if config.ignore_actuators: | ||
| self.actuators_to_test = list( | ||
| filter( | ||
| lambda actuator: actuator not in config.ignore_actuators, |
There was a problem hiding this comment.
lambda functions are not allowed per our development guidelines: https://developer.lsst.io/python/style.html#lambda-should-not-be-used
I would suggest doing something like:
self.actuators_to_test = [actuator_id for actuator_id in self.actuators_to_test if actuator_id not in config.ignore_actuators]
It is more clear and expressive than the implementation here.
tribeiro
approved these changes
Jul 11, 2023
dsanmartim
force-pushed
the
tickets/SITCOM-944
branch
from
c1d9ffb
to
a0bd48d
Compare
|
Tks for approving it. Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Tiago,
I did a quick implementation on this ticket. Can you take a look on the first try and tell me if anything else would be needed?